Fixed some Heap stuff and a typo #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicated that the Heaps shown are Max Heaps, so that the
description of the operations makes sense.
Fixed Binomial Heap description to be more comparable with
Fibonacci Heap description:
* Indicated amortized complexities where appropriate.
* Allowed Binomial Heap to use the same max-tracking
pointer that the Fibonacci Heap uses.
ericdrowell
added a commit
that referenced
this pull request
Mar 16, 2015
Fixed some Heap stuff and a typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks much for putting this sheet together.
I have a couple of patches to propose. One patch fixes the description of the Binomial Heap to be more comparable with the Fibonacci Heap description, and also marks the Heaps as Max Heaps so their operations make clear sense. The other patch fixes a typo.
You might consider checking some CSS and other infrastructure into the repo so that people can check their work locally before issuing pull requests. I've got something if you want it. The biggest problem is how to properly track the Bootstrap CSS.