Standardize application of color css classes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdrowell
added a commit
that referenced
this pull request
Mar 16, 2015
Standardize application of color css classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming colors are intended to help with us quickly compare different algorithms or data structures, it seems like the color styling--though subjective--should be applied consistently within each column. For example, mergesort and quicksort both have a worst-case O(n) running time, so they should have the same color styling applied. I have fixed several small inconsistencies like this.
I think it would be better overall if there were more css classes for each complexity class (something like progressively darker shades for constant, linear, log-linear, quadratic, etc) so that styling was less subjective, but you haven't made the stylesheet available in this repo.