Update html-minifier dependency to fix some problems #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
added a commit
that referenced
this pull request
Jul 3, 2014
Update html-minifier dependency to fix some problems
Owner
|
v0.5.6 is out for you! |
Author
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, I want to use the collaspeWhitespace option to reduce the size of my templates but html-minifier 0.5.4 has some problems where it is a bit too greedy with collapsing whitespace. For example:
html <input type='checkbox' /> Foois minified to:
html <input type='checkbox'>FooNote the missing whitespace in front of Foo, this whitespace is significant with regards to styling and shouldn't be stripped; 0.6+ fixes this problem.