Add slash escaping for usemin target on Windows #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Another similar solution here: #80 (the main difference is relying on node.js "path" instead of checking for the OS, both are valid options) |
Owner
|
@christianrondeau Let me know if this is still necessary, since |
Contributor
|
Both are addressing the same issue, so I don't believe this pull request to still be useful (if @jbalboni agrees with me) |
Author
|
Yep, I agree. Thanks @christianrondeau and @ericclemmons. |
Owner
|
YAY TEAMWORK! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a fix for the problem in issue #70. The workaround of specifying \ instead of / in the usemin target path works, but we run our grunt build process on Mac and Windows machines, so it would be nice to have one target that works for both platforms. Plus, it looks like the grunt/usemin convention is to use forward slashes everywhere.
I wasn't sure how to write a test for this, since the tests don't seem to work on Windows (on my machine, anyway).
Thanks!