Skip to content

Make the type selector work for UPPER case elements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stroiman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make the type selector work for UPPER case elements #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71a411
Make the type selector work for lower case elements
stroiman Jan 31, 2025
93b8a53
Move package to gost-dom project
stroiman Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# CSS selectors in Go

This library is a fork of [github.com/ericchiang/css](https://github.com/ericchiang/css) fixing issues experienced using [Gost-DOM](https://github.com/gost-dom/browser).

Note. This fork starts at version 0.1.0, as I imagine adding significant chagnes
to the public API, allowing it consume an interface; rather than the specific golang.org/x/net/html

---

[![Go Reference](https://pkg.go.dev/badge/github.com/ericchiang/css.svg)](https://pkg.go.dev/github.com/ericchiang/css)

This package implements a CSS selector compiler for Go's HTML parsing package golang.org/x/net/html.
Expand Down
2 changes: 1 addition & 1 deletion css.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ func (c *compiler) typeSelector(s *typeSelector) *typeSelectorMatcher {
if s.value == "*" {
m.allAtoms = true
} else {
a := atom.Lookup([]byte(s.value))
a := atom.Lookup([]byte(strings.ToLower(s.value)))
if a == 0 {
if c.errorf(s.pos, "unrecognized node name: %s", s.value) {
return nil
Expand Down
29 changes: 25 additions & 4 deletions css_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ type selectorTest struct {
}

var selectorTests = []selectorTest{
{
"A",
`<h1><a></a></h1>`,
[]string{`<a></a>`},
},
{
"a",
`<h1><a></a></h1>`,
Expand Down Expand Up @@ -333,7 +338,7 @@ var selectorTests = []selectorTest{
},
},
{
"body p em", // https://github.com/ericchiang/css/issues/7
"body p em", // https://github.com/gost-dom/css/issues/7
`
<html>
<body>
Expand Down Expand Up @@ -801,7 +806,13 @@ func TestSelector(t *testing.T) {
got = append(got, b.String())
}
if diff := cmp.Diff(test.want, got); diff != "" {
t.Errorf("Selecting %q (%s) from %s returned diff (-want, +got): %s", test.sel, s, in, diff)
t.Errorf(
"Selecting %q (%s) from %s returned diff (-want, +got): %s",
test.sel,
s,
in,
diff,
)
}
}
}
Expand All @@ -821,11 +832,21 @@ func TestBadSelector(t *testing.T) {
}
var perr *ParseError
if !errors.As(err, &perr) {
t.Errorf("Expected parsing %s to return error of type *ParseError, got %T: %v", test.sel, err, err)
t.Errorf(
"Expected parsing %s to return error of type *ParseError, got %T: %v",
test.sel,
err,
err,
)
continue
}
if test.pos != perr.Pos {
t.Errorf("Parsing %s returned unexpected position, got=%d, want=%d", test.sel, perr.Pos, test.pos)
t.Errorf(
"Parsing %s returned unexpected position, got=%d, want=%d",
test.sel,
perr.Pos,
test.pos,
)
}
}
}
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/ericchiang/css
module github.com/gost-dom/css

go 1.15

Expand Down