Skip to content

SOption[T] serialization #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

SOption[T] serialization #813

merged 1 commit into from
Jun 19, 2025

Conversation

sethdusek
Copy link
Collaborator

@sethdusek sethdusek commented Mar 15, 2025 •
edited
Loading

Closes #775

@coveralls
Copy link

coveralls commented Mar 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15722282285

Details

  • 63 of 96 (65.63%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 78.457%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-p2p/src/peer_spec.rs 10 12 83.33%
ergotree-ir/src/mir/constant.rs 41 72 56.94%
Files with Coverage Reduction New Missed Lines %
ergo-p2p/src/peer_database/in_memory.rs 1 86.36%
ergotree-ir/src/mir/constant.rs 2 64.19%
Totals Coverage Status
Change from base Build 15722078068: 0.01%
Covered Lines: 11960
Relevant Lines: 15244
💛 - Coveralls

@sethdusek sethdusek force-pushed the soptionserialization branch from 7f376fe to d30f714 Compare May 3, 2025 11:41
@sethdusek sethdusek force-pushed the soptionserialization branch 2 times, most recently from 880bf9d to 0c13829 Compare June 17, 2025 14:55
@sethdusek sethdusek marked this pull request as ready for review June 18, 2025 02:08
@sethdusek sethdusek force-pushed the soptionserialization branch from 0c13829 to 86989c5 Compare June 18, 2025 02:13
@sethdusek sethdusek requested a review from kushti June 18, 2025 11:35
@sethdusek sethdusek merged commit 2725f40 into ergoplatform:develop Jun 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOption[T] serialization support
3 participants
@sethdusek @coveralls @kushti