Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obtain node resource by model name #70

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

fmigneault
Copy link
Contributor

Because the ResourceTreeServicePostgreSQL can receive a custom model (as long as it implements same fields structure as Resource), it is possible to reuse this tree and all its useful methods for other similar tables.

I employ this in my repo to sync Resource (local) against RemoteResource that derives from Resource.

This fix retrieves the field by name of the model class instead of hardcoded auto0generated attribute named like default Resource model.

fmigneault added a commit to Ouranosinc/Magpie that referenced this pull request Mar 27, 2021
@ergo
Copy link
Owner

ergo commented Mar 31, 2021

Thank you!

@ergo ergo merged commit 85cb03e into ergo:master Mar 31, 2021
@fmigneault
Copy link
Contributor Author

@ergo Will it be possible to have 0.8.4 in a near future? Thanks in advance.

@ergo
Copy link
Owner

ergo commented Apr 18, 2021

@fmigneault I've made a new release for you along with some other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants