Updates to the MetGrid initialization and forcing pathway#2806
Draft
wiersema1 wants to merge 5 commits intoerf-model:developmentfrom
Draft
Updates to the MetGrid initialization and forcing pathway#2806wiersema1 wants to merge 5 commits intoerf-model:developmentfrom
wiersema1 wants to merge 5 commits intoerf-model:developmentfrom
Conversation
wiersema1
force-pushed
the
metgrid_updates
branch
from
bf8e38a to
7828c59
Compare
…memory bottlenecks and facilitate multilevel configurations. The MetGrid pathway now processes each time sequentially to reduce the memory footprint. Temporary variables were previously fabs, which introduced a memory bottleneck that scaled in severity with the number of ranks, but have been updated to MultiFabs to eliminiate this bottleneck.
wiersema1
force-pushed
the
metgrid_updates
branch
from
7828c59 to
78cc95b
Compare
Contributor
|
@wiersema1, my colleague has confirmed that this PR fixes his memory issue using the metgrid path -- so no need for his workaround, which was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These updates resolve some memory bottlenecks and facilitate multilevel configurations. The MetGrid pathway now processes each time sequentially to reduce the memory footprint. Temporary variables were previously fabs, which introduced a memory bottleneck that scaled in severity with the number of ranks, but have been updated to MultiFabs to eliminate this bottleneck.
Note: this is a second PR with a clean port of the changes from the original PR, which is to be closed and not merged.