This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Split dependencies of backends during tests. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been testing with both the haystack and elastic dependencies installed at once. This will be a problem when working with the postgres backend because it requires a specific version of Django. We'd like to keep testing the other versions of Django with haystack and elastic, so we need to set up a framework for testing separate backends with different dependencies installed.
Importing a `storage` had been triggering a call to `ElasticSearch`. Delaying until first use resolves this problem (which is particularly problematic in testing).
|
Coverage drop is misleading -- depending on tox config, different branches of code are tested. I'm not sure how to resolve that at the moment... |
Different test runs may exercise different chunks of code. To get a final code coverage metric, we need to aggregate the results.
tadhg-ohiggins
approved these changes
Aug 10, 2017
|
Thanks @tadhg-ohiggins |
cmc333333
pushed a commit
that referenced
this pull request
Aug 10, 2017
Breaking Changes * #79 "django.contrib.contenttypes" is now included in library's base settings. If copying these over, you'll need to deduplicate. New Features * #79 Allow search handler to be defined via `SEARCH_HANDLER` setting * #83 Allow search results page size to be requested * #82 Add Postgres backend for search. See README for details. Misc * #77 Allow ALLOWED_HOSTS to be set via env vars * #78 Use webargs library for checking search input * #80 Test different backends in different tox envs * #81 Remove QuantifiedCode badge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been testing with both the haystack and elastic dependencies installed
at once. This will be a problem when working with the postgres backend because
it requires a specific version of Django. We'd like to keep testing the other
versions of Django with haystack and elastic, so we need to set up a framework
for testing separate backends with different dependencies installed.