don't require executor parameter

[bryanlarsen]

The fix for #433 (socket file leak) added an executor parameter. However, to get the fix, users have to call executor.abort_all(). So the primary motivation for this fix is so that all users get the fix even if they don't call abort_all().

The secondary motivation is to make the API nicer.

[erebe]

I would avoid this one, as I really would like to pay the performace penality of joinSet only for people needing it.

I haven't had time to look to improve the executor interface. But it is possible to have the abort_all on drop. I just need to spend some time on it. I was busy merging the support of tls ECH to the server

[bryanlarsen]

That's reasonable. In the meantime, would you accept just the impl Drop? That eliminates one foot gun for other users.

[erebe]

this is going to be more pernicious because doing

let exec = JointSetExecutor() 
exec.spawn(task)
{
let going_to_abort = exec.clone()
}
// task is aborted

it needs a weak ref on tve executor

[erebe]

If you rebase on Head, the JoinSetTokioExecutor should now abort all the task on drop correctly

[bryanlarsen]

works for me.