Skip to content

Avoid editing of matplotlib rcParams in source code #3

@vinisalazar

Description

@vinisalazar

Hi,

Thank you for providing this package. I was trying to plot a biplot with your other package, pca, and was having the hardest time figuring out why my matplotlib rcParams were not coming into effect. Not only was the biplot not coming out the way I wanted, when I added it to my figure, it would also modify the other subplots in the figure.

Turns out it was due to this line: https://github.com/erdogant/scatterd/blob/cdeacf33fdcff3459a7d14959edab2d825fd4026/scatterd/scatterd.py#L269C1-L270C1

I would like to suggest either removing this statement and finding an alternative way to set the font properties, or at least adding a warning to other users that may run into similar problems (not sure if verbose mode would account for that?)

I'd be happy to submit a PR with proposed changes, if you would welcome that.

Thank you!
Vini

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions