Skip to content

Make SudoPolicy compatible with IUserOpPolicy #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Make SudoPolicy compatible with IUserOpPolicy #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions contracts/external/policies/SudoPolicy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,19 @@ pragma solidity ^0.8.23;

import "../../DataTypes.sol";
import {
IActionPolicy, I1271Policy, IPolicy, VALIDATION_SUCCESS, VALIDATION_FAILED
IUserOpPolicy,
IActionPolicy,
I1271Policy,
IPolicy,
VALIDATION_SUCCESS,
VALIDATION_FAILED
} from "../../interfaces/IPolicy.sol";
import { IERC165 } from "forge-std/interfaces/IERC165.sol";
import { SubModuleLib } from "../../lib/SubModuleLib.sol";
import { EnumerableSet } from "../../utils/EnumerableSet4337.sol";
import { PackedUserOperation } from "modulekit/external/ERC4337.sol";

contract SudoPolicy is IActionPolicy, I1271Policy {
contract SudoPolicy is IUserOpPolicy, IActionPolicy, I1271Policy {
using EnumerableSet for EnumerableSet.Bytes32Set;

event SudoPolicyInstalledMultiplexer(address indexed account, address indexed multiplexer, ConfigId indexed id);
Expand All @@ -33,6 +39,17 @@ contract SudoPolicy is IActionPolicy, I1271Policy {
emit IPolicy.PolicySet(configId, msg.sender, account);
}

function checkUserOpPolicy(
ConfigId, /*id*/
PackedUserOperation calldata /*userOp*/
)
external
pure
returns (uint256)
{
return VALIDATION_SUCCESS;
}

function checkAction(
ConfigId, /*id*/
address, /*account*/
Expand Down Expand Up @@ -63,7 +80,8 @@ contract SudoPolicy is IActionPolicy, I1271Policy {
}

function supportsInterface(bytes4 interfaceID) external pure override returns (bool) {
return interfaceID == type(IActionPolicy).interfaceId || interfaceID == type(I1271Policy).interfaceId
|| interfaceID == type(IERC165).interfaceId || interfaceID == type(IPolicy).interfaceId;
return interfaceID == type(IUserOpPolicy).interfaceId || interfaceID == type(IActionPolicy).interfaceId
|| interfaceID == type(I1271Policy).interfaceId || interfaceID == type(IERC165).interfaceId
|| interfaceID == type(IPolicy).interfaceId;
}
}