Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use trivy as a binary instead of a library #786

Merged
merged 21 commits into from
Jul 6, 2023
Merged

feat: use trivy as a binary instead of a library #786

merged 21 commits into from
Jul 6, 2023

Commits on Jul 6, 2023

  1. Install trivy binary into trivy-scanner image 

    Installs the published trivy binary to the trivy-scanner image. Make
variables TRIVY_BINARY_REPO TRIVY_BINARY_TAG, and TRIVY_BINARY_IMG have
been added to provide control over the versioning.

This is a beginning of a change intended to reduce maintentance and
to resolve resource issues that have arisen. Instead of using trivy as a
library (which has a constantly-shifting API), we will use the published
binary.

Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    f44a373 View commit details
    Browse the repository at this point in the history

  2. Begin work on new scanner code 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4d2b85a View commit details
    Browse the repository at this point in the history

  3. First implementation of new scanner 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    3fba80b View commit details
    Browse the repository at this point in the history

  4. Update main method to use new scanner 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    65c59d6 View commit details
    Browse the repository at this point in the history

  5. Ensure new scanner uses only specified runtime 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d91f122 View commit details
    Browse the repository at this point in the history

  6. Add image name to args list 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    546e065 View commit details
    Browse the repository at this point in the history

  7. Please the linter 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5dc74ec View commit details
    Browse the repository at this point in the history

  8. Remove dead code and refactor 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4a44233 View commit details
    Browse the repository at this point in the history

  9. Propagate trivy version to scanner binary 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    75aeae4 View commit details
    Browse the repository at this point in the history

  10. Update deps after removing trivy 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2e01854 View commit details
    Browse the repository at this point in the history

  11. Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>

    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    64d04fb View commit details
    Browse the repository at this point in the history

  12. Fix typos 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    a8c6752 View commit details
    Browse the repository at this point in the history

  13. Remove dead code and associated unit test 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    63aed3a View commit details
    Browse the repository at this point in the history

  14. Change cli invocation log to debug-only 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7c7cc98 View commit details
    Browse the repository at this point in the history

  15. Update deps 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    a742166 View commit details
    Browse the repository at this point in the history

  16. Remove unnecessary comment 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7e1300d View commit details
    Browse the repository at this point in the history

  17. Place constants in logical order 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e819a4b View commit details
    Browse the repository at this point in the history

  18. Add unit test structure and first test 

    For testing Config.cliArgs(...)

Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b0d2a6a View commit details
    Browse the repository at this point in the history

  19. Add comprehensive unit tests for Config.cliArgs(...) 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bb17c0a View commit details
    Browse the repository at this point in the history

  20. Bump k8s.io/kubernetes to v1.26.6 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    67a0fc4 View commit details
    Browse the repository at this point in the history

  21. Gofumpt unit test files 

    Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
    @pmengelbert
    pmengelbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    142d52a View commit details
    Browse the repository at this point in the history