fix: update owner references #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #773 +/- ##
=======================================
Coverage 14.83% 14.83%
=======================================
Files 13 13
Lines 1496 1496
=======================================
Hits 222 222
Misses 1253 1253
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
pmengelbert
requested changes
Jul 27, 2023
Comment on lines
271
to
272
| err = r.Delete(ctx, &template) | ||
| if err != nil { |
There was a problem hiding this comment.
nit:
Suggested change
| err = r.Delete(ctx, &template) | |
| if err != nil { | |
| if err := r.Delete(ctx, &template); err != nil { |
Comment on lines
260
to
267
| err = r.Get(ctx, | ||
| types.NamespacedName{ | ||
| Namespace: eraserUtils.GetNamespace(), | ||
| Name: job.GetName(), | ||
| }, | ||
| &template, | ||
| ) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err = r.Get(ctx, | |
| types.NamespacedName{ | |
| Namespace: eraserUtils.GetNamespace(), | |
| Name: job.GetName(), | |
| }, | |
| &template, | |
| ) | |
| if err != nil { | |
| if err := r.Get(ctx, | |
| types.NamespacedName{ | |
| Namespace: eraserUtils.GetNamespace(), | |
| Name: job.GetName(), | |
| }, | |
| &template, | |
| ); err != nil { |
Comment on lines
474
to
475
| err = r.List(ctx, &podList, client.InNamespace(utils.GetNamespace()), client.MatchingLabels{"control-plane": "controller-manager"}) | ||
| if err != nil { |
There was a problem hiding this comment.
nit:
Suggested change
| err = r.List(ctx, &podList, client.InNamespace(utils.GetNamespace()), client.MatchingLabels{"control-plane": "controller-manager"}) | |
| if err != nil { | |
| if err := r.List(ctx, &podList, client.InNamespace(utils.GetNamespace()), client.MatchingLabels{"control-plane": "controller-manager"}); err != nil { |
Comment on lines
238
to
245
| err = r.Get(ctx, | ||
| types.NamespacedName{ | ||
| Namespace: eraserUtils.GetNamespace(), | ||
| Name: job.GetName(), | ||
| }, | ||
| &template, | ||
| ) | ||
| if err != nil { |
Comment on lines
250
to
251
| err = r.Delete(ctx, &template) | ||
| if err != nil { |
Comment on lines
388
to
389
| err = r.List(ctx, &podList, client.InNamespace(utils.GetNamespace()), client.MatchingLabels{"control-plane": "controller-manager"}) | ||
| if err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes owner references to clean up all pods when deleting Eraser deployment. Eraser pods' owner references are now set to the jobtemplate, and the jobtemplate's owner references are set to the controller manager pod.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #634
Special notes for your reviewer:
Since ImageJob is not an object it does not have ObjectMeta field to set an owner reference.