catch v2.11.0 #195
Merged
catch v2.11.0 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am using master branch of FakeIt and Catch2. |
|
Why isn't this merged already? Can somebody clarify? |
shrgabor
suggested changes
May 6, 2020
…nternal macros were changed and that changes are ported here as follows: - removed macro CATCH_INTERNAL_UNSUPPRESS_PARENTHESES_WARNINGS - added macros CATCH_INTERNAL_START_WARNINGS_SUPPRESSION and CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION
Done. Cute related changes were in this branch because master was merged to our fork in wrong manner. I corrected it and cherrypicked commit with catch fixes from old branch. If someone is using previous commit than they should switch to new one because hash changed. I hope it will be available (means merged) into main repo in the near future. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated catch2 port regarding to changes in catch2 v 2.11.0. Catch2 internal macros were changed and that changes are ported here as follows: