Remove direct dependencies to wxsqlite3 and sqlite3lib from all plugins #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CMake if you have a dependency chain which looks like: A -> B -> C then CMake will automatically add the dependency A -> C for you. This means that we can remove all the direct dependencies on wxsqlite3 and sqlite3lib from all plugins if they're already linking against libcodelite.
eranif
added a commit
that referenced
this pull request
May 15, 2015
Remove direct dependencies to wxsqlite3 and sqlite3lib from all plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CMake if you have a dependency chain which looks like:
A -> B -> Cthen CMake will automatically add the dependency
A -> Cfor you.This means that we can remove all the direct dependencies on wxsqlite3 and sqlite3lib from all plugins if they're already linking against libcodelite.