[cleanup] Migrate CodeFormatter to nlohmann::json
#3769
+75
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranif
requested changes
Nov 27, 2025
| JSON root{ config_file }; | ||
| if (!root.isOk() || !root.toElement().isArray()) { | ||
| wxString content; | ||
| if (!FileUtils::ReadFileContent(config_file, content)) |
| SourceFormatterBase::FromJSON(json); | ||
| m_command = json["command"].toArrayString(); | ||
| m_workingDirectory = json["working_directory"].toString(); | ||
| m_command = JsonUtils::ToArrayString(json["command"]); |
Owner
There was a problem hiding this comment.
This might throw an exception, lets wrap it with try / catch block.
I suggest that we add new methods in JsonUtils.
For example:
template <typename T>
concept JsonExtractable = requires(const nlohmann::json& j)
{
{j.template get<T>()}->std::same_as<T>;
};
template <typename T>
inline std::optional<T> GetValue(const nlohmann::json& json, const std::string& name) requires JsonExtractable<T>
{
if (!json.contains(name)) {
return std::nullopt;
}
try {
return json[name].get<T>();
} catch (const std::exception&) {
return std::nullopt;
}
}We can later use with default value like this:
m_command = wxString::FromUTF8(JsonUtils::GetValue(json, "command").value_or(""));
Collaborator
Author
There was a problem hiding this comment.
I noticed afterward that all methods of JsonItem defaults it return value when "empty", whereas nlohmann throws exception for invalid access.
nlohmann::json::value(key, default_value) exists for that case too.
I have indeed to reworks my migrations.
| m_name = json["name"].toString(); | ||
| m_description = json["description"].toString(); | ||
| m_shortDescription = json["short_description"].toString(); | ||
| m_languages = JsonUtils::ToArrayString(json["languages"]); |
Owner
There was a problem hiding this comment.
See previous comment about exceptions in nlohmann::json
Jarod42
force-pushed
the
codeformatter_json_migration
branch
from
f21ef50 to
ddb2917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.