The layer should always be pickable for the readout panel to show val… #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues when hovering.
nilscb
added
bug
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 40.44% 40.44%
=======================================
Files 135 135
Lines 6038 6038
Branches 1446 1446
=======================================
Hits 2442 2442
Misses 3570 3570
Partials 26 26
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
hkfb
requested changes
May 20, 2022
| @@ -311,7 +311,7 @@ export default class Map3DLayer extends CompositeLayer< | |||
| >({ | |||
| mesh: this.state.mesh, | |||
| texture: this.state.texture, | |||
| pickable: this.props.pickable, | |||
| pickable: true, | |||
There was a problem hiding this comment.
I think there is reason to disable picking in some circumstances. But we should be able to enable picking when the onMouseEvent prop is specified and the readout panel is hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ues when hovering.