Fixed zoom for view with axes #976
Conversation
| @@ -403,7 +403,7 @@ export const Axes = MinimalTemplate.bind({}); | |||
| Axes.args = { | |||
| id: "axes", | |||
| layers: [axes, meshMapLayer, north_arrow_layer], | |||
| bounds: [432150, 6475800, 439400, 6481500], | |||
| bounds: [432205, 6475078, 437720, 6481113], | |||
There was a problem hiding this comment.
This bound should be same as axis bounds.
Ideally, project bounds should be calculated based on data bounds of all the layers.
There was a problem hiding this comment.
We have an issue for automatically calculating the bounds (#924), but until we have that in place, then I think using the bounds itself to set the initial viewport is the best solution.
shadab-skhan
added
bug
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
==========================================
- Coverage 42.90% 42.87% -0.04%
==========================================
Files 116 116
Lines 3801 3799 -2
Branches 716 716
==========================================
- Hits 1631 1629 -2
Misses 2147 2147
Partials 23 23
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
What is the problem we are solving with this? That the initial viewport is too small when the axes are shown? We have an issue for automatically calculating the bounds (#924), but until we have that in place, then I think using the bounds itself to set the initial viewport is the best solution. |
|
Before: After: This change only corrects the bounds of storybook example for axes story. |
| @@ -403,7 +403,7 @@ export const Axes = MinimalTemplate.bind({}); | |||
| Axes.args = { | |||
| id: "axes", | |||
| layers: [axes, meshMapLayer, north_arrow_layer], | |||
| bounds: [432150, 6475800, 439400, 6481500], | |||
| bounds: [432205, 6475078, 437720, 6481113], | |||
There was a problem hiding this comment.
We have an issue for automatically calculating the bounds (#924), but until we have that in place, then I think using the bounds itself to set the initial viewport is the best solution.
|
Discarding PR |
No description provided.