Refactoring codebase (Part1) #424
Merged
+41
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update output dir for dash components * update license in package.json * update package name to use the same convention as core components * disable generation of R dash components
alexandruandrei91
added
AspenTech
Good plan @alexandruandrei91 👍 Regarding the 🔴 from CI - I guess that is easily solved by instructing the CI workflow to know that In |
anders-kiaer
approved these changes
Jun 29, 2021
hkfb
pushed a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Nov 29, 2021
* Move react stuff to react/ * Update output dir for dash components * Update license in package.json * Update package name to use the same convention as core components * Disable generation of R dash components * Temporary disable the python tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to get to a similar setup as https://github.com/equinor/webviz-core-components
See also equinor/webviz-core-components#90 and equinor/webviz-core-components#125 for more details.
The main changes in this PR are:
react/folder, updatingpackage.jsonand andwebpack.config.jsfor it.Rcode generation.@webviz/subsurface-componentsto match the convention incore-components.package.jsonfromLGPLtoMPL.I've decided to push this refactoring in two parts to get the most disruptive part (moving react stuff into another folder) in as soon as possible, to minimize the merge conflicts.
Next I'll address the other changes needed, in a different PR.
Adds to #411