perf: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724 #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscb
added
enhancement
nilscb
changed the title
w1nklr
approved these changes
Oct 25, 2023
|
🎉 This issue has been resolved in version subsurface-viewer@0.5.3 🎉 The release is available on GitHub release |
nilscb
added a commit
to nilscb/webviz-subsurface-components
that referenced
this pull request
Oct 27, 2023
…ayer. - This is related to earlier commit. MapLayer was missing - Earlier commit: performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. equinor#1724 (equinor#1737)
w1nklr
pushed a commit
that referenced
this pull request
Oct 27, 2023
hkfb
pushed a commit
that referenced
this pull request
Oct 27, 2023
## [0.5.4](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.5.3...subsurface-viewer@0.5.4) (2023-10-27) ### Performance Improvements * Apply flag "ZIncreasingDownwards" in vertex shaders MapLayer. ([#1741](#1741)) ([ed85f7f](ed85f7f)), closes [#1724](#1724) [#1737](#1737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will complete the fix for this issue: #1724
"Performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724"
This PR contains fix for the last layer in this issue: TriangleLayer.
It will also fix the readout for this layer.