-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: irrelevant X, Y, Z readout for map layer #1731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nilscb
commented
Oct 23, 2023
•
edited by w1nklr
Loading
edited by w1nklr
- performance: handle ZIncreasingDownwards by the shader for map layer Performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724
- fix incorrect X, Y and Z coordinates returned by the mouse event for the map layer 3D cursor readout gives irrelevant X, Y, Z/depth numbers #1654
…ers for relevant layers. equinor#1724
…rrect readout of depth. equinor#1723"
nilscb
added
enhancement
New feature or request
AspenTech
Task owned by AspenTech
map-component
Issues related to the map component.
labels
Oct 23, 2023
w1nklr
changed the title
refactor: Map readout fix
fix: irrelevant X, Y, Z readout for map layer
Oct 23, 2023
w1nklr
approved these changes
Oct 23, 2023
🎉 This issue has been resolved in version subsurface-viewer@0.4.3 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AspenTech
Task owned by AspenTech
enhancement
New feature or request
map-component
Issues related to the map component.
released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.