Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent situation where width is defined and 0 #1726

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented Oct 20, 2023

No description provided.

@nilscb nilscb requested review from hkfb and w1nklr October 20, 2023 13:33
@nilscb nilscb added bug Something isn't working AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Oct 20, 2023
Copy link
Collaborator

@w1nklr w1nklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed an other fix to handle all the places where the issue can occur...

@nilscb nilscb merged commit 54470e6 into equinor:master Oct 20, 2023
5 checks passed
hkfb pushed a commit that referenced this pull request Oct 20, 2023
@hkfb
Copy link
Collaborator

hkfb commented Oct 20, 2023

🎉 This issue has been resolved in version subsurface-viewer@0.4.1 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Oct 20, 2023
@nilscb nilscb deleted the FixInfinity branch December 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech bug Something isn't working map-component Issues related to the map component. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants