Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bump Deck.gl to latest version. #1696

Merged
merged 2 commits into from
Oct 13, 2023
Merged

build: Bump Deck.gl to latest version. #1696

merged 2 commits into from
Oct 13, 2023

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented Oct 13, 2023

-This should contain a fix for the scrolling issues we have experienced.

@nilscb nilscb requested review from w1nklr and hkfb October 13, 2023 07:28
@nilscb nilscb self-assigned this Oct 13, 2023
@nilscb nilscb added dependencies Pull requests that update a dependency file AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Oct 13, 2023
@nilscb nilscb changed the title dep: Bump Deck.gl to latest version. build: Bump Deck.gl to latest version. Oct 13, 2023
hkfb
hkfb requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add your package-lock.json also.

@w1nklr
Copy link
Collaborator

w1nklr commented Oct 13, 2023

Need to add your package-lock.json also.

Good catch !

nilscb added 2 commits October 13, 2023 09:46
@nilscb
dep: Bump Deck.gl to latest version.
3299b03 
 _ This should contain a fix for the scrolling issues we have experienced.
@nilscb
Add package-lock.json
1f3d9cf
hkfb
hkfb reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or do the wells look slightly blurred now?

image

@w1nklr
Copy link
Collaborator

w1nklr commented Oct 13, 2023

Is it just me or do the wells look slightly blurred now?

image

They are blurred, but it is already the case in the published storybook (ie. if there is a regression, it does not come from this PR):

Image from the storybbok:
image

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

Is it just me or do the wells look slightly blurred now?
image

They are blurred, but it is already the case in the published storybook (ie. if there is a regression, it does not come from this PR):

Image from the storybbok: image

The upper image looks more blurry to me.

@nilscb
Copy link
Collaborator Author

nilscb commented Oct 13, 2023

Its a bit hard to say. I agree that the upper appears slightly more blurred

hkfb
hkfb approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change to approved and let you decide. I think we should drop a note to deck.gl about the blurred polygons

@nilscb nilscb merged commit a603666 into equinor:master Oct 13, 2023
5 checks passed
@w1nklr
Copy link
Collaborator

w1nklr commented Oct 13, 2023

I confirm that there is no visible difference in full-screen on my machine.

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 0.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb hkfb added the released label Oct 13, 2023
@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hkfb
Copy link
Collaborator

hkfb commented Oct 13, 2023

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nilscb nilscb deleted the BumpDeck branch December 7, 2023 16:34
@hkfb
Copy link
Collaborator

hkfb commented Dec 12, 2023

🎉 This issue has been resolved in version group-tree-plot@1.0.0 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w1nklr w1nklr w1nklr approved these changes

@hkfb hkfb hkfb approved these changes

Assignees

@nilscb nilscb

Labels
AspenTech Task owned by AspenTech dependencies Pull requests that update a dependency file map-component Issues related to the map component. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilscb @w1nklr @hkfb