Cypress component test #1257
Merged
Cypress component test #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1257 +/- ##
=======================================
Coverage 36.45% 36.45%
=======================================
Files 149 149
Lines 8163 8163
Branches 2188 2188
=======================================
Hits 2976 2976
Misses 5153 5153
Partials 34 34 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
avanti-em
force-pushed
the
cypress_component_test
branch
from
f97e70a to
2cfc599
Compare
added 2 commits
October 28, 2022 15:20
avanti-em
force-pushed
the
cypress_component_test
branch
from
18b355e to
eb8b99a
Compare
added 14 commits
October 31, 2022 11:44
…-components into cypress_component_test
…-components into cypress_component_test
…-components into cypress_component_test
| run: | | ||
| mkdir clone | ||
| cd clone | ||
| git clone --branch cypress-snaps --depth 1 --filter=blob:none https://github.com/avanti-em/webviz-subsurface-components |
There was a problem hiding this comment.
Should this be changed to official repo before merge?
There was a problem hiding this comment.
Oops! I forgot to change it. Thanks for catching.
| @@ -155,7 +181,7 @@ jobs: | |||
| run: npm run build-storybook --prefix ./react | |||
|
|
|||
| - name: 📚 Update Storybook and GitHub demo application | |||
| if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]')) && matrix.python-version == '3.8' | |||
| if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]')) && matrix.python-version == '3.8' && failure() && matrix.e2e-tests | |||
There was a problem hiding this comment.
For my understanding: Why do we want to update official storybook only on failure?
There was a problem hiding this comment.
I think I did some kind of mistake while I was doing some "search and replace" stuff. Its a complete mistake, I will undo it.
| body: This is an auto-generated PR to update cypress snapshots. | ||
| base: cypress-snaps | ||
| reviewers: ${{ github.event.sender.login }} | ||
| delete-branch: true |
There was a problem hiding this comment.
Got it, will fix it
avanti-em
force-pushed
the
cypress_component_test
branch
3 times, most recently
from
c035d0e to
9c97b25
Compare
…-components into cypress_component_test
avanti-em
force-pushed
the
cypress_component_test
branch
2 times, most recently
from
8070a8b to
9330d2c
Compare
avanti-em
force-pushed
the
cypress_component_test
branch
from
e16d1b8 to
624605c
Compare
anders-kiaer
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.