fix: color of undefined value for 3D grids is incorrect (#2253)

The color was way to clear, and was missing the 0-255 to 0-1 conversion.
equinor · Sep 23, 2024 · d53b213 · d53b213
1 parent 4c27540
commit d53b213
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/typescript/packages/subsurface-viewer/src/layers/grid3d/grid3dLayer.ts b/typescript/packages/subsurface-viewer/src/layers/grid3d/grid3dLayer.ts
@@ -428,9 +428,9 @@ export default class Grid3DLayer extends CompositeLayer<Grid3DLayerProps> {
             this.props.propertiesData.length === 0 &&
             this.isColorMapFunctionConstantColor(colorFunc)
         ) {
-            return [colorFunc[0] / 255, colorFunc[1] / 255, colorFunc[2] / 255];
+            return [colorFunc[0], colorFunc[1], colorFunc[2]];
         }
-        return this.props.undefinedPropertyColor ?? [0.8, 0.8, 0.8];
+        return this.props.undefinedPropertyColor ?? [204, 204, 204];
     }
 
     private isColorMapFunctionConstantColor(

diff --git a/typescript/packages/subsurface-viewer/src/layers/grid3d/privateGrid3dLayer.ts b/typescript/packages/subsurface-viewer/src/layers/grid3d/privateGrid3dLayer.ts
@@ -352,6 +352,14 @@ export default class PrivateLayer extends Layer<PrivateLayerProps> {
         const colorMapClampColorUniform = colorMapClampColor.map(
             (x) => (x ?? 0) / 255
         );
+
+        const undefinedPropertyColorUniform =
+            this.props.undefinedPropertyColor.map((x) => (x ?? 0) / 255) as [
+                number,
+                number,
+                number,
+            ];
+
         const isColorMapClampColorTransparent: boolean =
             (this.props.colorMapClampColor as boolean) === false;
 
@@ -362,7 +370,7 @@ export default class PrivateLayer extends Layer<PrivateLayerProps> {
             valueRangeMax,
             colorMapRangeMin,
             colorMapRangeMax,
-            undefinedPropertyColor: this.props.undefinedPropertyColor,
+            undefinedPropertyColor: undefinedPropertyColorUniform,
             colorMapClampColor: Array.from(colorMapClampColorUniform),
             isColorMapClampColorTransparent,
             isClampColor,