Merged
Conversation
- Add OMEGAA_list/OMEGAB_list declarations to read(String,String[]) method (they were parsed and used but never declared, causing 'Unresolved compilation problems' at runtime for testSetAllocationComposition tests) - Update testFluidWater3 expected enthalpy: now -4639.239569... because OMEGAA=0.45724 from fluid_water.E300 is applied (vs default 0.45724333333) - Update testSetAllocationComposition expected x_methane_A19: now 0.0046202120... because A-19.E300 OMEGAA values are now applied correctly - Fix neqsim_dev_setup.py: when recompile=False and JVM already running, return valid namespace reusing existing JVM instead of returning None Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- JsonProcessBuilder.createFluidByModel: add PR_LK/PR-LK/PRLK cases (previously unsupported, 'Unknown thermodynamic model' error) - neqsim-unisim-reader SKILL: document PRLKCORR/OMEGAA/OMEGAB/BICS E300 keywords, forced-EOS read overload, water BIP+OmegaA interaction warning - neqsim-api-patterns SKILL: add PR-LK to EOS table, document all optional E300 sections, read(path,fluid) overload, JSON model name PR_LK Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…qsim into improve-unisim-reader
- Add OMEGAA_list/OMEGAB_list declarations to read(String,String[]) method (they were parsed and used but never declared, causing 'Unresolved compilation problems' at runtime for testSetAllocationComposition tests) - Update testFluidWater3 expected enthalpy: now -4639.239569... because OMEGAA=0.45724 from fluid_water.E300 is applied (vs default 0.45724333333) - Update testSetAllocationComposition expected x_methane_A19: now 0.0046202120... because A-19.E300 OMEGAA values are now applied correctly - Fix neqsim_dev_setup.py: when recompile=False and JVM already running, return valid namespace reusing existing JVM instead of returning None Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- JsonProcessBuilder.createFluidByModel: add PR_LK/PR-LK/PRLK cases (previously unsupported, 'Unknown thermodynamic model' error) - neqsim-unisim-reader SKILL: document PRLKCORR/OMEGAA/OMEGAB/BICS E300 keywords, forced-EOS read overload, water BIP+OmegaA interaction warning - neqsim-api-patterns SKILL: add PR-LK to EOS table, document all optional E300 sections, read(path,fluid) overload, JSON model name PR_LK Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to NeqSim! Please complete the following checklist before requesting review:
./mvnw testruns successfullySee CONTRIBUTING.md for the full contribution process.