Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization of robot in state machine #278

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Initialization of robot in state machine #278

merged 2 commits into from
Jun 3, 2022

Conversation

vetlek
Copy link
Contributor

@vetlek vetlek commented May 30, 2022

Closes #273

@vetlek vetlek self-assigned this May 30, 2022
GodVenn
GodVenn reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Please see comments

src/isar/apis/models/models.py Outdated Show resolved Hide resolved
src/isar/state_machine/states/initialize.py Show resolved Hide resolved
src/isar/state_machine/states/initialize.py Outdated Show resolved Hide resolved
@GodVenn GodVenn self-requested a review June 3, 2022 12:42
GodVenn
GodVenn approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vetlek vetlek merged commit 31d99f7 into equinor:main Jun 3, 2022
@vetlek vetlek deleted the initialization branch June 3, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodVenn GodVenn GodVenn approved these changes

Assignees

@vetlek vetlek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add initialization of robot
2 participants
@vetlek @GodVenn