Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publishing of status messages over MQTT #264

Merged
merged 2 commits into from
May 19, 2022
Merged

Update publishing of status messages over MQTT #264

merged 2 commits into from
May 19, 2022

Conversation

vetlek
Copy link
Contributor

@vetlek vetlek commented May 16, 2022

No description provided.

@vetlek
Copy link
Contributor Author

vetlek commented May 18, 2022

Closes #266

@vetlek vetlek self-assigned this May 18, 2022
GodVenn
GodVenn reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Please see the comments for discussion.

src/isar/config/settings.py Outdated Show resolved Hide resolved
src/isar/state_machine/states/finalize.py Outdated Show resolved Hide resolved
src/isar/state_machine/states/monitor.py Show resolved Hide resolved
GodVenn
GodVenn reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments

src/isar/models/mission/status.py Outdated Show resolved Hide resolved
src/isar/state_machine/state_machine.py Outdated Show resolved Hide resolved
src/isar/state_machine/state_machine.py Outdated Show resolved Hide resolved
src/isar/state_machine/states/initiate_step.py Outdated Show resolved Hide resolved
GodVenn
GodVenn suggested changes May 19, 2022
View reviewed changes
src/isar/state_machine/state_machine.py Outdated Show resolved Hide resolved
@vetlek vetlek requested a review from GodVenn May 19, 2022 07:05
@GodVenn GodVenn linked an issue May 19, 2022 that may be closed by this pull request
Update publishing of status over MQTT #266
Closed
GodVenn
GodVenn approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vetlek vetlek merged commit b509e2b into equinor:main May 19, 2022
@vetlek vetlek deleted the update_mqtt_publishing branch May 19, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodVenn GodVenn GodVenn approved these changes

Assignees

@vetlek vetlek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update publishing of status over MQTT
2 participants
@vetlek @GodVenn