-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of robot capabilities before starting mission #241
Conversation
Require updates to the robot specific libraries (otherwise default values that might not be correct will be provided) |
c279a3e
to
bfb40e5
Compare
bfb40e5
to
61c5606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move the factory inside the class. When that is fixed, I approve of this PR.
61c5606
to
9d1bb3b
Compare
env_file_path = None | ||
super().__init__(_env_file=env_file_path) | ||
|
||
CAPABILITIES: List[str] = Field(default=["drive_to_pose", "take_image"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this looks even better :)
Closes #134