Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of robot capabilities before starting mission #241

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

vetlek
Copy link
Contributor

@vetlek vetlek commented Apr 11, 2022

Closes #134

@vetlek vetlek self-assigned this Apr 11, 2022
@vetlek
Copy link
Contributor Author

vetlek commented Apr 11, 2022

Require updates to the robot specific libraries (otherwise default values that might not be correct will be provided)

src/isar/apis/schedule/start_mission.py Outdated Show resolved Hide resolved
src/isar/mission_planner/mission_validator.py Outdated Show resolved Hide resolved
@vetlek
Copy link
Contributor Author

vetlek commented Apr 12, 2022

Linked PR in isar-robot

@vetlek
Copy link
Contributor Author

vetlek commented Apr 12, 2022

@vetlek vetlek force-pushed the validate_robot_capabilities branch from bfb40e5 to 61c5606 Compare April 12, 2022 10:45
@vetlek vetlek requested a review from tsundvoll April 12, 2022 10:47
Copy link
Contributor

@tsundvoll tsundvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move the factory inside the class. When that is fixed, I approve of this PR.

src/isar/config/settings.py Outdated Show resolved Hide resolved
@vetlek vetlek force-pushed the validate_robot_capabilities branch from 61c5606 to 9d1bb3b Compare April 12, 2022 11:15
env_file_path = None
super().__init__(_env_file=env_file_path)

CAPABILITIES: List[str] = Field(default=["drive_to_pose", "take_image"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this looks even better :)

@vetlek vetlek merged commit 69a28b2 into equinor:main Apr 12, 2022
@vetlek vetlek deleted the validate_robot_capabilities branch April 12, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation of missions compatibility to robot
2 participants