Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pydantic settings management #230

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Use pydantic settings management #230

merged 2 commits into from
Mar 17, 2022

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Mar 10, 2022 •
edited
Loading

Closes #219 and #207

@aeshub aeshub added the improvement Improvement to existing functionality label Mar 10, 2022
@aeshub aeshub self-assigned this Mar 10, 2022
@aeshub aeshub force-pushed the pydantic-settings branch 4 times, most recently from 69eb286 to 5a7ea40 Compare March 10, 2022 13:37
This was linked to issues Mar 10, 2022
Fix failing integration test for turtlebot #207
Closed
Use pydantic settings management for configuration #219
Closed
@aeshub aeshub mentioned this pull request Mar 11, 2022
Closed
GodVenn
GodVenn approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@GodVenn GodVenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub aeshub merged commit 6b953d5 into equinor:main Mar 17, 2022
@aeshub aeshub deleted the pydantic-settings branch March 17, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GodVenn GodVenn GodVenn approved these changes

Assignees

@aeshub aeshub

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pydantic settings management for configuration Fix failing integration test for turtlebot
2 participants
@aeshub @GodVenn