Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): add config builder callback args to process config method #924

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

asbjornhaland
Copy link
Contributor

Why

We add config builder callbacks so that configurator can process config with the builder callback args - for instance !requireInstance`

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: c58d456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-framework-module Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🐞 bug Something isn't working label Jun 7, 2023
@asbjornhaland asbjornhaland requested a review from Noggling June 7, 2023 08:04
@asbjornhaland asbjornhaland force-pushed the fix/module-add-init-to-process-config branch from 88a0eb2 to c58d456 Compare June 7, 2023 08:05
@odinr odinr merged commit 060818e into main Jun 7, 2023
@odinr odinr deleted the fix/module-add-init-to-process-config branch June 7, 2023 08:33
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants