Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove requirement of leading slash in main attr #910

Merged
merged 1 commit into from
May 30, 2023

Conversation

asbjornhaland
Copy link
Contributor

This will fix so that both "main": "src/index.ts" and "main": "/src/index.ts" will resolve.

Closes #908

Why

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

@asbjornhaland asbjornhaland requested a review from a team May 30, 2023 12:52
@asbjornhaland asbjornhaland self-assigned this May 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

🦋 Changeset detected

Latest commit: a3078b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-framework-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@asbjornhaland asbjornhaland force-pushed the fix/remove-requirement-of-leading-slash-in-main branch from 1d5239c to f9b972a Compare May 30, 2023 12:55
This will fix so that both `"main": "src/index.ts"` and `"main":
"/src/index.ts"` will resolve.

Closes #908
@asbjornhaland asbjornhaland force-pushed the fix/remove-requirement-of-leading-slash-in-main branch from f9b972a to a3078b2 Compare May 30, 2023 13:05
@github-actions github-actions bot added 🐞 bug Something isn't working 💾 CLI fusion framework CLI labels May 30, 2023
@asbjornhaland asbjornhaland added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit d40951a May 30, 2023
@asbjornhaland asbjornhaland deleted the fix/remove-requirement-of-leading-slash-in-main branch May 30, 2023 13:18
@github-actions github-actions bot mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💾 CLI fusion framework CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the requirement of leading / in main attribute in package.json
2 participants