Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module): allow multilevel config #882

Merged
merged 1 commit into from
May 31, 2023
Merged

feat(module): allow multilevel config #882

merged 1 commit into from
May 31, 2023

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented May 23, 2023

No description provided.

@odinr odinr requested a review from a team May 23, 2023 13:19
@odinr odinr self-assigned this May 23, 2023
eikeland
eikeland previously approved these changes May 23, 2023
View reviewed changes
@asbjornhaland
Copy link
Contributor

I'm working on another solution that should be more type-safe.

@odinr odinr closed this May 25, 2023
@odinr odinr reopened this May 25, 2023
@odinr odinr closed this May 25, 2023
@odinr odinr reopened this May 30, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e531382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-framework-module Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🧬 Modules labels May 30, 2023
@asbjornhaland asbjornhaland force-pushed the feat/modules/module/allow-multilevel-config branch from cc4456e to f0d7e6d Compare May 30, 2023 08:19
@github-actions github-actions bot removed the 🐞 bug Something isn't working label May 30, 2023
@asbjornhaland asbjornhaland force-pushed the feat/modules/module/allow-multilevel-config branch 2 times, most recently from 9f370c4 to a602c0d Compare May 30, 2023 08:40
@asbjornhaland asbjornhaland assigned asbjornhaland and unassigned odinr May 30, 2023
@asbjornhaland asbjornhaland requested review from a team and eikeland May 30, 2023 08:47
eikeland
eikeland reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@eikeland eikeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix lint warnings first on BaseConfigBuilder.

@asbjornhaland asbjornhaland force-pushed the feat/modules/module/allow-multilevel-config branch 2 times, most recently from 86cad60 to c6ad765 Compare May 30, 2023 13:52
@asbjornhaland asbjornhaland requested a review from eikeland May 30, 2023 14:00
@asbjornhaland asbjornhaland force-pushed the feat/modules/module/allow-multilevel-config branch from c6ad765 to e531382 Compare May 31, 2023 07:10
@asbjornhaland
Copy link
Contributor

All lint warnings are now fixed.

@asbjornhaland asbjornhaland added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit 76b30c1 May 31, 2023
@asbjornhaland asbjornhaland deleted the feat/modules/module/allow-multilevel-config branch May 31, 2023 07:46
@github-actions github-actions bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikeland eikeland eikeland approved these changes

Assignees

@asbjornhaland asbjornhaland

Labels
🚀 feature New feature or request 🏗️ framework ✨ improvement 🧬 Modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odinr @asbjornhaland @eikeland