Skip to content

Commit

Permalink
build: update changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
odinr committed May 28, 2023
1 parent a7858a1 commit d6671bc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .changeset/stale-pigs-leave.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,3 @@ __🚧 Chore: dedupe packages__
- align all versions of typescript
- update types to build
- a couple of typecasts did not [satisfies](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html#satisfies-support-in-jsdoc) and was recasted as `unknwon`, marked with `TODO`, should be fixed in future
- added missing [exhausted-deps](https://legacy.reactjs.org/docs/hooks-rules.html), this might cause rerender, since `ReactRouterDom.createBrowserHistory` might create history dynamicly.
- this should be tested in portal when updating the `@equinor/fusion-framework-legacy-interopt`
- https://github.com/equinor/fusion-framework/blob/7c0a475174f61ba02570614c237d5cfb3b009cb1/packages/react/legacy-interopt/src/create-legacy-render.tsx#L59
9 changes: 9 additions & 0 deletions .changeset/stale-pigs-leave_2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@equinor/fusion-framework-legacy-interopt": patch
---

added missing [exhausted-deps](https://legacy.reactjs.org/docs/hooks-rules.html), this might cause rerender, since `ReactRouterDom.createBrowserHistory` might create history dynamicly.

this should be tested in portal when updating the `@equinor/fusion-framework-legacy-interopt`

https://github.com/equinor/fusion-framework/blob/7c0a475174f61ba02570614c237d5cfb3b009cb1/packages/react/legacy-interopt/src/create-legacy-render.tsx#L59

0 comments on commit d6671bc

Please sign in to comment.