Fix <= .to3 migrations causing .to7 gendata migration failure #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
bugfix-subtle-migration-silenterr
branch
from
bd9a931
to
b683743
Compare
yngve-sk
force-pushed
the
bugfix-subtle-migration-silenterr
branch
from
b683743
to
7ef9667
Compare
yngve-sk
changed the title
yngve-sk
added
the
release-notes:bug-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9048 +/- ##
==========================================
- Coverage 90.85% 90.85% -0.01%
==========================================
Files 352 352
Lines 21757 21759 +2
==========================================
+ Hits 19768 19769 +1
- Misses 1989 1990 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.to3migrations are currently dumping responses.json based on theResponseConfig, so then it is already migrated. Code in.to7assumes it is not migrated. This was also not being caught by the storage migration test as it checked only for summary data.Checking for it in the test makes it fail: https://github.com/equinor/ert/actions/runs/11514769298/job/32054192381