Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get measured data using active realizations #6188

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Get measured data using active realizations #6188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aa0069
Get measured data using active realizations
dafeda Sep 25, 2023
e3e6551
Test that measured data work with failed reals
dafeda Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/ert/data/_measured_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
import numpy as np
import pandas as pd

from ert.realization_state import RealizationState

if TYPE_CHECKING:
import numpy.typing as npt

Expand Down Expand Up @@ -103,10 +105,13 @@ def _get_data(
group, obs = observations.get_dataset(key)
try:
response = ensemble.load_response(
group, tuple(range(self._facade.get_ensemble_size()))
group, tuple(ensemble.realization_list(RealizationState.HAS_DATA))
)
except KeyError:
raise ResponseError(f"No response loaded for observation key: {key}")
_msg = f"No response loaded for observation key: {key}"
if not response:
raise ResponseError(_msg)
except KeyError as e:
raise ResponseError(_msg) from e
ds = obs.merge(
response,
join="left",
Expand Down
4 changes: 4 additions & 0 deletions tests/unit_tests/gui/test_full_manual_update_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from qtpy.QtCore import Qt, QTimer
from qtpy.QtWidgets import QApplication, QComboBox, QMessageBox, QPushButton, QWidget

from ert.data import MeasuredData
from ert.gui.ertwidgets.caselist import CaseList
from ert.gui.simulation.ensemble_experiment_panel import EnsembleExperimentPanel
from ert.gui.simulation.run_dialog import RunDialog
Expand Down Expand Up @@ -129,6 +130,9 @@ def handle_dialog():
df_prior = facade.load_all_gen_kw_data(storage.get_ensemble_by_name("iter-0"))
df_posterior = facade.load_all_gen_kw_data(storage.get_ensemble_by_name("iter-1"))

# Making sure measured data works with failed realizations
MeasuredData(facade, storage.get_ensemble_by_name("iter-0"), ["POLY_OBS"])

# We expect that ERT's update step lowers the
# generalized variance for the parameters.
assert (
Expand Down
Loading