Fix compatibility wity beartype==0.9.1 #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
maintenance
Codecov Report
@@ Coverage Diff @@
## main #2633 +/- ##
=======================================
Coverage 64.82% 64.82%
=======================================
Files 648 648
Lines 54188 54188
Branches 4517 4517
=======================================
+ Hits 35128 35129 +1
Misses 17653 17653
+ Partials 1407 1406 -1
Continue to review full report at Codecov.
|
pinkwah
reviewed
Dec 22, 2021
|
The error in type-checking is caused by this it seems: python/mypy#9951 |
Needed to add upper limit in mypy
berland
force-pushed
the
beartype-0.9.1
branch
from
ffcbb12
to
b72a134
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2632
Approach
Follow up breaking change from beartype 0.8.1 to 0.9.x. Bump beartype requirements in setup.py. Komodo bleeding already has version 0.9.1
Pre review checklist