Bump version to 0.3.6 #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErlendHaa
force-pushed
the
release
branch
4 times, most recently
from
3bb5e09 to
0399b4e
Compare
achaikou
reviewed
Mar 17, 2022
There was a problem hiding this comment.
Bad news:
We need tags, something like
push:
branches: [master]
tags:
- '*'
Otherwise job was not triggered
Good news:
Image with full link works, but it must be the Raw link
https://raw.githubusercontent.com/equinor/dlisio/master/dlisio-logo.svg
Assuming that the logo file is always located in the same directory as the README doesn't always hold. This is the case on e.g. PyPi, where only the README itself read before rendering. Causing the logo to not display. Setting the image to a rawlink rather then a relative path solves that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.