Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update ts-config #853

Closed
wants to merge 5 commits into from
Closed

[WIP] Update ts-config #853

wants to merge 5 commits into from

Conversation

vnys
Copy link
Member

@vnys vnys commented Nov 9, 2020

resolves #826

  • Updated React to v17 in core-react
  • Ran npx react-codemod update-react-imports to remove React imports

TODO

  • Typescript needs to be updated to 4.1 beta to support the new React 17 JSX factories that allows us to remove import React from 'react' from all the components
  • The storybook needs to be run with --no-dll to avoid problems with React 17.

@vnys
Copy link
Member Author

vnys commented Nov 9, 2020

Feels like I’m on my way down a rabbit hole with this issue. I think maybe I’ll backtrack and postpone upgrading React to v17 until Typescript 4.1 is out of beta. What do you think?

@vnys
Copy link
Member Author

vnys commented Nov 10, 2020

Closing as it became quite messy in the end. Replaced by #859

@vnys vnys closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant