Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover and tooltip consistensy #488

Merged
merged 7 commits into from
Aug 25, 2020

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Aug 17, 2020

Margin-right: auto on both anchors needed for them to not ruin table cell structure. See the 'Custom Table' the Table examples in the Storybook.

@pomfrida pomfrida changed the title [WIP] Popover and tooltip consistensy Popover and tooltip consistensy Aug 18, 2020
@pomfrida pomfrida marked this pull request as ready for review August 18, 2020 09:48
@wenche wenche self-requested a review August 18, 2020 11:51
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as far as I can see, the table example highlights the issue in the storefront with the arrow marker being calculated to the wrong place
Skjermbilde 2020-08-19 kl  10 36 45

@pomfrida
Copy link
Contributor Author

@wenche Omg 🤣 🔫 Simple magic fixes everything: display: inline-flex instead of flex. I'll remove the custom table demo before merging, it's just for you guys to see

@pomfrida pomfrida requested a review from wenche August 20, 2020 12:06
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pomfrida pomfrida force-pushed the Tooltip-Popover-Constistensy branch 2 times, most recently from e19d7be to 16e64f8 Compare August 25, 2020 07:19
@pomfrida pomfrida merged commit f5f18f3 into equinor:develop Aug 25, 2020
wenche pushed a commit that referenced this pull request Aug 27, 2020
* Popover and tooltip examples in tables

* Popover display: inline-flex fixes alignment issues in tables

* Same fix for Tooltip

* Tests updated after change

* Removed unused code

* Removed test table story
wenche pushed a commit to wenche/design-system that referenced this pull request Aug 27, 2020
* Popover and tooltip examples in tables

* Popover display: inline-flex fixes alignment issues in tables

* Same fix for Tooltip

* Tests updated after change

* Removed unused code

* Removed test table story
@pomfrida pomfrida deleted the Tooltip-Popover-Constistensy branch October 19, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants