Skip to content

Conversation

@torleifhalseth
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings September 17, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the token build system by removing the eds-tokens-sync dependency from the eds-tokens-build package and reorganizing imports to create a cleaner separation of concerns. The refactoring moves color and typography variable generation functions from the build package back to the tokens package, while keeping shared utilities in the build package.

Key changes:

  • Removal of eds-tokens-sync dependency from eds-tokens-build package
  • Import reorganization to use utilities from eds-tokens-build instead of local implementations
  • Enhanced mergeLightDarkFoundation function with improved configurability and type safety

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/eds-tokens/src/generate-variables/index.ts Updates imports to use local implementations instead of build package exports
packages/eds-tokens/src/generate-variables/createSpacingAndTypographyVariables.ts Reorganizes imports to use utilities from build package
packages/eds-tokens/src/generate-variables/createColorVariablesStatic.ts Updates imports to use shared utilities from build package
packages/eds-tokens/src/generate-variables/createColorVariablesFoundation.ts Consolidates imports to use build package utilities
packages/eds-tokens/src/generate-variables/createColorVariablesDynamic.ts Updates imports to use shared utilities from build package
packages/eds-tokens-build/vite.config.ts Removes eds-tokens-sync from external dependencies
packages/eds-tokens-build/src/utils/mergeLightDarkFoundation.ts Enhances function with comprehensive options interface and improved configurability
packages/eds-tokens-build/src/main.ts Updates exports to include enhanced mergeLightDarkFoundation utilities
packages/eds-tokens-build/package.json Removes eds-tokens-sync dependency
packages/eds-tokens-build/README.md Updates documentation with improved examples for color variable generation
package.json Simplifies build:variables script by removing eds-tokens-sync build step
DockerfileEdsDocs Removes eds-tokens-sync build step from Docker build process
DockerfileEdsDemo Removes eds-tokens-sync package.json copy step
DockerfileColorPaletteGenerator Removes eds-tokens-sync package.json copy step

@torleifhalseth torleifhalseth force-pushed the refactor/tokens-build-sync-setup branch from 018376c to 3fee700 Compare September 17, 2025 08:59
@pomfrida pomfrida changed the title Refactor/tokens build sync setup refactor: tokens build sync setup Sep 17, 2025
@pomfrida pomfrida changed the title refactor: tokens build sync setup refactor(eds-tokens, eds-tokens-build): tokens build sync setup Sep 17, 2025
@torleifhalseth torleifhalseth changed the title refactor(eds-tokens, eds-tokens-build): tokens build sync setup refactor(eds-tokens): tokens build sync setup Sep 18, 2025
@torleifhalseth torleifhalseth merged commit df07db9 into develop Sep 18, 2025
6 checks passed
@torleifhalseth torleifhalseth deleted the refactor/tokens-build-sync-setup branch September 18, 2025 11:48
magnh pushed a commit that referenced this pull request Oct 13, 2025
* refactor (eds-tokens-build): Move eds specific build scripts to eds-tokens
* refactor (eds-tokens): Move eds specific build scripts to eds-tokens

* feat(eds-tokens-build): Add README support for light/dark CSS color variables and remove unused dependency

* refactor: remove the eds-tokens-sync dependency from the docker files and build script

* fix: update pnpm lock after removing dependency to tokens-sync in tokens-build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants