-
Notifications
You must be signed in to change notification settings - Fork 70
refactor(eds-tokens): tokens build sync setup #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the token build system by removing the eds-tokens-sync dependency from the eds-tokens-build package and reorganizing imports to create a cleaner separation of concerns. The refactoring moves color and typography variable generation functions from the build package back to the tokens package, while keeping shared utilities in the build package.
Key changes:
- Removal of
eds-tokens-syncdependency fromeds-tokens-buildpackage - Import reorganization to use utilities from
eds-tokens-buildinstead of local implementations - Enhanced
mergeLightDarkFoundationfunction with improved configurability and type safety
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/eds-tokens/src/generate-variables/index.ts | Updates imports to use local implementations instead of build package exports |
| packages/eds-tokens/src/generate-variables/createSpacingAndTypographyVariables.ts | Reorganizes imports to use utilities from build package |
| packages/eds-tokens/src/generate-variables/createColorVariablesStatic.ts | Updates imports to use shared utilities from build package |
| packages/eds-tokens/src/generate-variables/createColorVariablesFoundation.ts | Consolidates imports to use build package utilities |
| packages/eds-tokens/src/generate-variables/createColorVariablesDynamic.ts | Updates imports to use shared utilities from build package |
| packages/eds-tokens-build/vite.config.ts | Removes eds-tokens-sync from external dependencies |
| packages/eds-tokens-build/src/utils/mergeLightDarkFoundation.ts | Enhances function with comprehensive options interface and improved configurability |
| packages/eds-tokens-build/src/main.ts | Updates exports to include enhanced mergeLightDarkFoundation utilities |
| packages/eds-tokens-build/package.json | Removes eds-tokens-sync dependency |
| packages/eds-tokens-build/README.md | Updates documentation with improved examples for color variable generation |
| package.json | Simplifies build:variables script by removing eds-tokens-sync build step |
| DockerfileEdsDocs | Removes eds-tokens-sync build step from Docker build process |
| DockerfileEdsDemo | Removes eds-tokens-sync package.json copy step |
| DockerfileColorPaletteGenerator | Removes eds-tokens-sync package.json copy step |
…pts to eds-tokens
…ariables and remove unused dependency
… and build script
018376c to
3fee700
Compare
* refactor (eds-tokens-build): Move eds specific build scripts to eds-tokens * refactor (eds-tokens): Move eds specific build scripts to eds-tokens * feat(eds-tokens-build): Add README support for light/dark CSS color variables and remove unused dependency * refactor: remove the eds-tokens-sync dependency from the docker files and build script * fix: update pnpm lock after removing dependency to tokens-sync in tokens-build.
No description provided.