-
Notifications
You must be signed in to change notification settings - Fork 71
feat(design-system-docs): colour foundation #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca96556
to
ef539fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds print functionality to the color palette generator application, enabling users to create clean printouts of color scales. The implementation includes print-specific CSS styles and responsive classes to hide/show elements appropriately when printing.
Key changes:
- Adds comprehensive print styles with utility classes for hiding interactive elements
- Updates components to use print-responsive classes for better print layouts
- Improves documentation structure and fixes minor formatting issues
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
packages/eds-color-palette-generator/src/styles/print.css | New print stylesheet with utility classes and print-specific overrides |
packages/eds-color-palette-generator/src/components/ColorScale.tsx | Adds print-responsive classes to hide interactive elements and adjust layouts |
packages/eds-color-palette-generator/src/app/page.tsx | Applies print-hide classes to interactive sections and adjusts grid layouts |
packages/eds-color-palette-generator/src/app/layout.tsx | Imports the new print stylesheet globally |
documentation/how-to/REBASE_GUIDE.md | Improves documentation structure and clarity |
apps/design-system-docs/docs/resources/resources.md | Minor formatting improvements |
apps/design-system-docs/docs/foundation/colour/*.md | New color foundation documentation files |
.vscode/settings.json | Adds design-system-docs to conventional commit scopes |
.github/copilot-instructions.md | Minor formatting improvements to project overview |
gridTemplateColumns: `repeat(${colors.length}, minmax(0, 1fr))`, | ||
}} | ||
> | ||
<div className="grid grid-cols-15 gap-2 mb-4 print:mb-0 print:gap-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded grid-cols-15
class assumes exactly 15 color steps. This creates a tight coupling between the CSS and the color configuration. Consider using dynamic grid columns based on the actual colors array length to maintain flexibility.
<div className="grid grid-cols-15 gap-2 mb-4 print:mb-0 print:gap-0"> | |
<div | |
className={`grid gap-2 mb-4 print:mb-0 print:gap-0 grid-cols-[${colors.length}]`} | |
> |
Copilot uses AI. Check for mistakes.
/* Print-specific overrides for better layout */ | ||
@media print { | ||
/* Enhanced interactive element hiding */ | ||
/* button[type='button'], */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented-out selector should either be removed if not needed or uncommented with an explanation of why it's disabled. Leaving commented code without context makes maintenance unclear.
/* button[type='button'], */ |
Copilot uses AI. Check for mistakes.
1c83db5
to
82af47e
Compare
Added a short intro to the semantic categories section.
Added some intro texts to the sections.
Some changes in the Feature section.
3463047
to
9dcc96f
Compare
No description provided.