Skip to content

Conversation

torleifhalseth
Copy link
Collaborator

No description provided.

@torleifhalseth torleifhalseth changed the title Feat/thalse-colour-foundation-docs feat (design-system-docs): colour foundation Sep 11, 2025
@torleifhalseth torleifhalseth force-pushed the feat/thalse-colour-foundation-docs branch 4 times, most recently from ca96556 to ef539fc Compare September 12, 2025 12:49
@torleifhalseth torleifhalseth marked this pull request as ready for review September 15, 2025 09:32
@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 09:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds print functionality to the color palette generator application, enabling users to create clean printouts of color scales. The implementation includes print-specific CSS styles and responsive classes to hide/show elements appropriately when printing.

Key changes:

  • Adds comprehensive print styles with utility classes for hiding interactive elements
  • Updates components to use print-responsive classes for better print layouts
  • Improves documentation structure and fixes minor formatting issues

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/eds-color-palette-generator/src/styles/print.css New print stylesheet with utility classes and print-specific overrides
packages/eds-color-palette-generator/src/components/ColorScale.tsx Adds print-responsive classes to hide interactive elements and adjust layouts
packages/eds-color-palette-generator/src/app/page.tsx Applies print-hide classes to interactive sections and adjusts grid layouts
packages/eds-color-palette-generator/src/app/layout.tsx Imports the new print stylesheet globally
documentation/how-to/REBASE_GUIDE.md Improves documentation structure and clarity
apps/design-system-docs/docs/resources/resources.md Minor formatting improvements
apps/design-system-docs/docs/foundation/colour/*.md New color foundation documentation files
.vscode/settings.json Adds design-system-docs to conventional commit scopes
.github/copilot-instructions.md Minor formatting improvements to project overview

gridTemplateColumns: `repeat(${colors.length}, minmax(0, 1fr))`,
}}
>
<div className="grid grid-cols-15 gap-2 mb-4 print:mb-0 print:gap-0">
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded grid-cols-15 class assumes exactly 15 color steps. This creates a tight coupling between the CSS and the color configuration. Consider using dynamic grid columns based on the actual colors array length to maintain flexibility.

Suggested change
<div className="grid grid-cols-15 gap-2 mb-4 print:mb-0 print:gap-0">
<div
className={`grid gap-2 mb-4 print:mb-0 print:gap-0 grid-cols-[${colors.length}]`}
>

Copilot uses AI. Check for mistakes.

/* Print-specific overrides for better layout */
@media print {
/* Enhanced interactive element hiding */
/* button[type='button'], */
Copy link
Preview

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out selector should either be removed if not needed or uncommented with an explanation of why it's disabled. Leaving commented code without context makes maintenance unclear.

Suggested change
/* button[type='button'], */

Copilot uses AI. Check for mistakes.

@pomfrida pomfrida changed the title feat (design-system-docs): colour foundation feat(design-system-docs): colour foundation Sep 17, 2025
@torleifhalseth torleifhalseth force-pushed the feat/thalse-colour-foundation-docs branch from 1c83db5 to 82af47e Compare September 24, 2025 08:52
@torleifhalseth torleifhalseth linked an issue Sep 29, 2025 that may be closed by this pull request
@torleifhalseth torleifhalseth force-pushed the feat/thalse-colour-foundation-docs branch from 3463047 to 9dcc96f Compare September 29, 2025 11:22
@torleifhalseth torleifhalseth merged commit e341fa0 into develop Sep 29, 2025
6 checks passed
@torleifhalseth torleifhalseth deleted the feat/thalse-colour-foundation-docs branch September 29, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write documentation for colour tokens (developers)
4 participants