fix: fixes issue where sidebar default state always starts as closed #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikMWold
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the sidebar component where setting the
openstate totrueby default results in an initial layout shift. The component briefly renders as closed before opening, causing an unwanted animation.Issue
The issue stems from using a
useEffectto sync the internal state with theopenprop, leading to a mismatch on initial render.Fix
The internal state now defaults directly to the
openprop, ensuring the sidebar renders correctly without unnecessary transitions.