EDS Data Grid Feature: onRowContextMenu #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlastad
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
yusijs
reviewed
Oct 21, 2024
|
Feature looks good (aside from the comment I added re. Popover). Someone from the core team would need to do the final review though (pinging @oddvernes) |
|
I changed it to use a menu instead, as that is more in line with what it probably will be used for. |
oddvernes
approved these changes
Oct 21, 2024
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a
onRowContextMenufeature to allow for right-click on table rows.We need this to be able to use context menus on tables generated using Eds Data Grid.
onRowContextMenuworks the same as the already existingonRowClickfunctionality. It just uses the other mouse button.Tests and storybook is updated, and runs.
If there's anything I've missed, please let me know.