-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Autocomplete select all: consider disabled items #3429
🐛 Autocomplete select all: consider disabled items #3429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/eds-core-react/src/components/Autocomplete/Autocomplete.tsx
Outdated
Show resolved
Hide resolved
I have now taken into account that a disabled item can be selected, and the "select all" toggle will only select/deselect items that are not disabled. I also made a change to the "x / y selected" text, where y used to be |
* 🐛 Autocmplete: select all: consider disabled items * optimize optionDisabled initialization * consider selected disabled items in "select all" * clear button: consider disabled selected items * renaming variables * update story
resolves #3427
changes
optionDisabled
to an external const so it does not break useMemo's where it is a dependency