Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): garden popover not closing on outside click #500

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

Gustav-Eikaas
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas commented Aug 21, 2023

Fixed a bug where outside click does not close the garden popover.

@Gustav-Eikaas
Copy link
Contributor Author

Gustav-Eikaas commented Aug 21, 2023

Affected apps

  • Workorder
  • Loop
  • Punch
  • Handover

@Gustav-Eikaas Gustav-Eikaas self-assigned this Aug 21, 2023
@Gustav-Eikaas Gustav-Eikaas added the bug Something isn't working label Aug 21, 2023
@Gustav-Eikaas Gustav-Eikaas requested review from espenkalle, MagnusGjosund and a team and removed request for MagnusGjosund and espenkalle August 21, 2023 06:11
@espenkalle
Copy link
Contributor

Ikke lø ws 4.0.3 ut enda vel?

@Gustav-Eikaas
Copy link
Contributor Author

deploy test

@github-actions
Copy link

Deployed! 🚀

@AreWiv
Copy link
Contributor

AreWiv commented Aug 21, 2023

Tested - verified for

  • Workorder
  • Loop
  • Punch

Handover does not seem to work as expected.

Would also ask for slightly better description - which popover/box is affected.

@AreWiv
Copy link
Contributor

AreWiv commented Aug 21, 2023

Tested again after refresh. Handover also works.

Change status to Ready for Prod/Done.

@Gustav-Eikaas Gustav-Eikaas merged commit d3676c9 into main Aug 21, 2023
3 checks passed
@Gustav-Eikaas Gustav-Eikaas deleted the fix/garden-popover-close-on-click-outside branch August 21, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants