Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate fusion app management v2 pipelines #1165

Merged
merged 44 commits into from
Nov 6, 2024

Conversation

Gustav-Eikaas
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas commented Nov 5, 2024

Short summary

Working code for test pipeline with following changes.

New pipeline requires a semver version and will not accept duplicate versions.

Solved by retrieving latest version from server and incrementing by one. (The intention is for app teams to utilize changesets, this is not suitable for us and will impede our workflow)

App config

Multiple changes to the app config. Today we use this to automatically add 3d configuration to all apps, and adding useful stuff like pr number and commit sha. The commit sha has been the most useful so far and is now natively supported in fusion app admin v2.
Debating whether its worth migrating this functionality as it is an ease-of-use thing and could be removed. Most apps have the configuration propagated already and is rarely changed..

Remaining work

Publish 1.0.0 version of all apps to remove the -legacy flag which would probably mess with the increment version function

Remaining work for prod.

Nothing has been done here yet

Reference

  • equinor/fusion-rfcs#70

@Gustav-Eikaas Gustav-Eikaas requested a review from a team as a code owner November 5, 2024 09:33
Copy link
Contributor

@kjellhaaland kjellhaaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gustav-Eikaas Gustav-Eikaas merged commit 1ce2cf7 into main Nov 6, 2024
5 checks passed
@Gustav-Eikaas Gustav-Eikaas deleted the ci/migrate-pipelines branch November 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: migrate fusion app management v2 pipelines
2 participants