-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate fusion app management v2 pipelines #1165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…components into ci/migrate-pipelines
Gustav-Eikaas
commented
Nov 6, 2024
Gustav-Eikaas
commented
Nov 6, 2024
kjellhaaland
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary
Working code for test pipeline with following changes.
New pipeline requires a semver version and will not accept duplicate versions.
Solved by retrieving latest version from server and incrementing by one. (The intention is for app teams to utilize changesets, this is not suitable for us and will impede our workflow)
App config
Multiple changes to the app config. Today we use this to automatically add 3d configuration to all apps, and adding useful stuff like pr number and commit sha. The commit sha has been the most useful so far and is now natively supported in fusion app admin v2.
Debating whether its worth migrating this functionality as it is an ease-of-use thing and could be removed. Most apps have the configuration propagated already and is rarely changed..
Remaining work
Publish 1.0.0 version of all apps to remove the
-legacy
flag which would probably mess with the increment version functionRemaining work for prod.
Nothing has been done here yet
Reference