Map LOG_LEVEL to new aws powertools log level variables.

[paultop6]

No description provided.

[dxd1]

It't a good idea but would it make sense to expect them to be set and fall back to LOG_LEVEL only if not?

[paultop6]

It't a good idea but would it make sense to expect them to be set and fall back to LOG_LEVEL only if not?

I dont quite follow what you mean?

Not every services sets LOG_LEVEL, so it would make sense to have it conditionally map it to the new log level variables only if LOG_LEVEL has itself been set.

[dxd1]

What I mean is that this way they will get overwitten if LOG_LEVEL is set.

[paultop6]

What I mean is that this way they will get overwitten if LOG_LEVEL is set.

That should be the intention. https://linear.app/epsy/issue/BE-810/%5Bserverless-builder%5D-support-for-new-env-variables-used-by-aws-lambda

[dxd1]

This way we need to support a deprecated env var and we can't separate the 2 if we want to. Would something like this make sense?

 if "LOG_LEVEL" in self.envs:
            self.envs["AWS_LAMBDA_LOG_LEVEL"] = self.envs.get("AWS_LAMBDA_LOG_LEVEL", self.envs["LOG_LEVEL"])
            self.envs["POWERTOOLS_LOG_LEVEL"] = self.envs.get("POWERTOOLS_LOG_LEVEL", self.envs["LOG_LEVEL"])

This way we only owerride the values if they're not already set

[paultop6]

This way we need to support a deprecated env var and we can't separate the 2 if we want to. Would something like this make sense?

 if "LOG_LEVEL" in self.envs:
            self.envs["AWS_LAMBDA_LOG_LEVEL"] = self.envs.get("AWS_LAMBDA_LOG_LEVEL", self.envs["LOG_LEVEL"])
            self.envs["POWERTOOLS_LOG_LEVEL"] = self.envs.get("POWERTOOLS_LOG_LEVEL", self.envs["LOG_LEVEL"])

This way we only owerride the values if they're not already set

Ok I understand what you mean now.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud