feature: Allow to define LogGroup for function
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to set `Properties` for `LogGroup` which is created for lambda function.
Real use cases for that can be when you want to modify default `30` days of `RetentionInDays` or add `DataProtectionPolicy`
Usage:
```python
service.builder.function.generic(
“my-function”,
“Handle requests",
handler=“my_module.appsync.handler",
log_group=dict(Properties=dict(RetentionInDays=3653))
)
```
serverless/aws/functions/generic.py
Outdated
Comment on lines
104
to
103
| log_group = dict(Type="AWS::Logs::LogGroup", Properties=dict(RetentionInDays=30)) | ||
| log_group_properties = kwargs.pop("log_group", {}).get("Properties") if kwargs.get("log_group", {}).get("Properties") else dict(RetentionInDays=30) | ||
|
|
||
| log_group = dict(Type="AWS::Logs::LogGroup", Properties=log_group_properties) |
There was a problem hiding this comment.
I think there might be a bug here if you have a log_group argument containing an "falsey" Properties value. It wouldn't pop the log_group argument in that case, and then it would get included in the loop at the end of the function.
I think this would achieve basically the same thing:
log_group_properties = kwargs.pop("log_group", {}).get("Properties") or dict(RetentionInDays=30)
raymondbutcher
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to set
PropertiesforLogGroupwhich is created for lambda function.Real use cases for that can be when you want to modify default
30days ofRetentionInDaysor addDataProtectionPolicyUsage: